Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix volume_mounts parsing for jobs and definition for pod creation #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix volume_mounts parsing for jobs and definition for pod creation #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contents/job-create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def create_job_object(data):
)

if "volume_mounts" in data:
volumes_array = data["volume_mounts"].splitlines()
volumes_array = data["volume_mounts"].split(",")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @natalia-pokrovskaya
Why do you use split in this line if you moved the variable to yaml?
maybe we need to use yaml.full_load(data["volume_mounts"]) instead

Luis

tmp = dict(s.split('=', 1) for s in volumes_array)

mounts = []
Expand Down
6 changes: 5 additions & 1 deletion plugin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1525,10 +1525,12 @@ providers:
- name: volume_mounts
type: String
title: "Volume Mounts"
description: "Volume Mounts, name=mountPath format. Use comma for multiples volume "
description: "Volume Mounts, yaml format "
required: false
renderingOptions:
groupName: Container
displayType: MULTI_LINE
codeSyntaxMode: yaml
- name: config_file
type: String
title: "Kubernetes Config File Path"
Expand Down Expand Up @@ -1979,6 +1981,8 @@ providers:
required: false
renderingOptions:
groupName: Container
displayType: MULTI_LINE
codeSyntaxMode: yaml
- name: volumes
type: String
title: "Volumes"
Expand Down