Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use protobuf-java 4.29.2 #395

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

loudmouth
Copy link

Fixes #392

All the things I reported in #392 suggested that there was a mismatch between protobuf-java and protoc. The documentation for protobuf and protobuf-java states:

Make sure the version number of the runtime matches (or is newer than) the version number of the protoc.

I confirmed that this works by adding the following to my own project and have now succesesfully built java_proto_library and java_grpc_library that usedon repeated enum:

# both of these are needed to properly override the rules_proto_grpc_java
bazel_dep(name = "rules_proto_grpc", version = "5.0.1")
git_override(
    module_name = "rules_proto_grpc",
    commit = "fdc3c887479dfe8da152c4863393388da0f40dfa",
    remote = "https://github.com/justtechnologies/rules_proto_grpc",
    strip_prefix = "modules/core",
)
bazel_dep(name = "rules_proto_grpc_java", version = "5.0.1")
git_override(
    module_name = "rules_proto_grpc_java",
    commit = "fdc3c887479dfe8da152c4863393388da0f40dfa",
    remote = "https://github.com/justtechnologies/rules_proto_grpc",
    strip_prefix = "modules/java",
)

@github-actions github-actions bot added dependencies Pull requests that update a dependency file lang-java Java rules specific labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file lang-java Java rules specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java: Imported enums from local dependency proto files cannot be used as repeated members
1 participant