Make transaction explicitly a deposit

- Fix spec to be more explicit
rubyforgood · Jun 1, 2024 · cb649ea · cb649ea
1 parent f9bdd0c
commit cb649ea
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/app/controllers/admin/students_controller.rb b/app/controllers/admin/students_controller.rb
@@ -49,7 +49,11 @@ def update
     def create_portfolio_transaction!
       return unless fund_amount.present?
 
-      PortfolioTransaction.create!(portfolio: requested_resource.portfolio, amount: fund_amount) if fund_amount
+      PortfolioTransaction.create!(
+        portfolio: requested_resource.portfolio,
+        amount: fund_amount,
+        transaction_type: 'deposit'
+      )
     end
 
     def fund_amount

diff --git a/test/controllers/admin/students_controller_test.rb b/test/controllers/admin/students_controller_test.rb
@@ -33,6 +33,7 @@ class Admin::StudentsControllerTest < ActionDispatch::IntegrationTest
 
     transaction = PortfolioTransaction.last
 
+    assert_equal 'deposit', transaction.transaction_type
     assert_equal 10.50, transaction.amount
     assert_equal @student.reload.portfolio.portfolio_transactions.last, transaction
 
@@ -43,9 +44,5 @@ class Admin::StudentsControllerTest < ActionDispatch::IntegrationTest
     assert_difference('PortfolioTransaction.count', 0) do
       patch admin_student_url(@student), params: { student: { add_fund_amount: '' } }
     end
-
-    transaction = PortfolioTransaction.last
-
-    assert_equal nil, transaction.amount
   end
 end