851 create form submission model

[Gabe-Torres]

🔗 Issue

(#851)

✍️ Description

Create form_submission model

• create test for form_submission model
• create the foreign key for has many relationship between form_submission and submitted_answer
• create the foreign key for has many relationship between form_submission and adopter_application
• update submitted_answer model test to include new association with form_submission
• update adopter_applicaiton model test to include new association with form_submission
  • Added an associations context block
  • this also involved creating a form_submission factory that can be called within tests

📷 Screenshots/Demos

[kasugaijin]

@Gabe-Torres This is looking good so far! Like you said, the pipeline is not passing because the seeds are not loading due to an error - my immediate guess is that AdopterApplication and SubmittedAnswer do not have a FormSubmission to belong to. So it will be a matter of creating that object and passing it to its associations in both Baja and Alta seeds files. I usually like to just focus on one seed file first and get that working, then it's more or less a copy paste into the other file as they should be almost identical.

To your questions about adding in the additional components to get the tests to pass - ideally, yes. PRs should be complete and always pass the pipeline. This will likely mean updating the seeds to make sure associated objects exist, and to update any test setups that also need the object to exist. Now, if this is starting to look like a huge chunk of work, we can always help you out! Let me know what you think! Ask as many questions as you need.

I usually try to break things up more into smaller chunks. But, given this is addition of a model, we need to add it and make sure it's working as expected. So, it's a bit more work...but should not be too much more as it's just two associated models. Famous last words.

[kasugaijin]

Ah I guess this was missing before! Thanks for adding.

[Gabe-Torres]

context "associations" do

@Gabe-Torres This is looking good so far! Like you said, the pipeline is not passing because the seeds are not loading due to an error - my immediate guess is that AdopterApplication and SubmittedAnswer do not have a FormSubmission to belong to. So it will be a matter of creating that object and passing it to its associations in both Baja and Alta seeds files. I usually like to just focus on one seed file first and get that working, then it's more or less a copy paste into the other file as they should be almost identical.

To your questions about adding in the additional components to get the tests to pass - ideally, yes. PRs should be complete and always pass the pipeline. This will likely mean updating the seeds to make sure associated objects exist, and to update any test setups that also need the object to exist. Now, if this is starting to look like a huge chunk of work, we can always help you out! Let me know what you think! Ask as many questions as you need.

I usually try to break things up more into smaller chunks. But, given this is addition of a model, we need to add it and make sure it's working as expected. So, it's a bit more work...but should not be too much more as it's just two associated models. Famous last words.

Thank you for the feedback @kasugaijin ! I can get sidetracked sometimes, so it's good to know I was on the right track. I updated tests where needed and made some tweaks to the adopter_applications factory to account for the new association with form_submissions.

Regarding seeds – How are we planning to handle a form_submission instance? In my current version, I created one form_submission object that has an association with the organization at the top of the file, along with a singular person. The seeds create 10 adopter applications. Do you think it would make sense to also create 10 form_submissions, or would that suffice for our needs?

[kasugaijin]

context "associations" do

@Gabe-Torres This is looking good so far! Like you said, the pipeline is not passing because the seeds are not loading due to an error - my immediate guess is that AdopterApplication and SubmittedAnswer do not have a FormSubmission to belong to. So it will be a matter of creating that object and passing it to its associations in both Baja and Alta seeds files. I usually like to just focus on one seed file first and get that working, then it's more or less a copy paste into the other file as they should be almost identical.
To your questions about adding in the additional components to get the tests to pass - ideally, yes. PRs should be complete and always pass the pipeline. This will likely mean updating the seeds to make sure associated objects exist, and to update any test setups that also need the object to exist. Now, if this is starting to look like a huge chunk of work, we can always help you out! Let me know what you think! Ask as many questions as you need.
I usually try to break things up more into smaller chunks. But, given this is addition of a model, we need to add it and make sure it's working as expected. So, it's a bit more work...but should not be too much more as it's just two associated models. Famous last words.

Thank you for the feedback @kasugaijin ! I can get sidetracked sometimes, so it's good to know I was on the right track. I updated tests where needed and made some tweaks to the adopter_applications factory to account for the new association with form_submissions.

Regarding seeds – How are we planning to handle a form_submission instance? In my current version, I created one form_submission object that has an association with the organization at the top of the file, along with a singular person. The seeds create 10 adopter applications. Do you think it would make sense to also create 10 form_submissions, or would that suffice for our needs?

So the benefit of the FormSubmission is that we should be able to associated multiple adopter applications with a single FormSubmission, so let's go with that in the seeds for now.

[kasugaijin]

Check out other resources that belong to an organization (most of them) and you'll see we use the acts as tenant helper here. This is important for setting the tenancy, or scope, for a given record i.e., which org it belongs to, and is used by the acts as tenant scoping logic elsewhere.

acts_as_tenant(:organization)

[kasugaijin]

@Gabe-Torres Looking great! Just a few comments.

[Gabe-Torres]

Awesome! I changed the belongs_to association to acts_as_tenant. Thank you @kasugaijin. I think everything is updated and ready to go!

[kasugaijin]

@Gabe-Torres approved, but please add the comments to the class per my comment above.

[Gabe-Torres]

Added! Apologies, I had added the comments before merging the most recent main and must of not added them while sorting conflicts.