Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix #852

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Bug Fix #852

merged 2 commits into from
Jun 27, 2024

Conversation

kasugaijin
Copy link
Collaborator

@kasugaijin kasugaijin commented Jun 26, 2024

🔗 Issue

N/A

✍️ Description

Playing in the dev environment I noted that we were getting a translation error after submitting an application on a pet. Calling send on the status enum value was returning an error because it is not a method. We need to pass the status symbol rather than value to this method for it to work.

To reproduce, on main branch, log in as an adopter and apply to adopt a pet. You should see:
image

@kasugaijin kasugaijin requested a review from jmilljr24 June 26, 2024 22:41
@kasugaijin kasugaijin self-assigned this Jun 26, 2024
…tion submitted

Update usage of this helper.

Pass the status symbol to the method not the status value
@kasugaijin kasugaijin force-pushed the bug-fix-application-status branch from b14aab0 to df586ee Compare June 26, 2024 23:09
Copy link
Collaborator

@jmilljr24 jmilljr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix!

app/views/organizations/adoptable_pets/show.html.erb Outdated Show resolved Hide resolved
@kasugaijin kasugaijin merged commit 217cd5b into main Jun 27, 2024
5 checks passed
@kasugaijin kasugaijin deleted the bug-fix-application-status branch June 27, 2024 00:51
ErinClaudio pushed a commit that referenced this pull request Jun 27, 2024
* Fix translation error on pet show page for an adopter with an application submitted

Update usage of this helper.

Pass the status symbol to the method not the status value

* add translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants