-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update with Image frontend buttons #618
Conversation
Bumps [debug](https://github.com/ruby/debug) from 1.9.1 to 1.9.2. - [Release notes](https://github.com/ruby/debug/releases) - [Commits](ruby/debug@v1.9.1...v1.9.2) --- updated-dependencies: - dependency-name: debug dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
… NEEDS TO BE UNDONE
* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* commit annotation change * update contacts create route to use post and update url on contacts form * add tests for contacts * replace hardcoded url, add instance variable for org name to use in mailer * replace current_tenant because it was coming up nil * add scope to contact form and update controller action to use stong params * update tests to use correct params format * fix test desciptions
* Move constants outside of class * Add active staff requirement to InvitationPolicy * Correct StaffAccountPolicyTest file name * Add active staff requirement to StaffAccountPolicy * Refactor AdoptablePetPolicy rule to utilize allowed_to? instead of checking permissions directly to benefit from other policy's prechecks * Fix pets factory traits to associate has_ relationship objects correctly * Add relation_scope test for AdoptablePetPolicyTest * Fix factory trait to work with build strategy
* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
…631) * Add toggle Stimulus controller * Modify Geeks UI CSS
Co-authored-by: Ben Robinson <[email protected]>
… NEEDS TO BE UNDONE
Hey @ErinClaudio the implementation looks good! Just a couple small details to tweak. For tests, I think we can handle setting up the PageText differently - see my comment on that. Also, when I run the tests locally, this test keeps failing for me (though in the pipeline it passes, so maybe there's something going on locally for me...does it pass for you locally?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @ErinClaudio! This is good chunk of work that adds value to the customization of the home page for each org. Thank you for seeing it through!
🔗 Issue
#592
✍️ Description
I do not like how the about us images upload but I could use a little feedback
📷 Screenshots/Demos