-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
479 480 page text controller and edit form #552
479 480 page text controller and edit form #552
Conversation
fffc0bd
to
c1109a3
Compare
</div> | ||
<!-- About Us --> | ||
<div class="form-group"> | ||
<%= form.text_field :about, label: "About Us", placeholder: "About Us text", class: 'form-control' %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change this to a text area instead? This input should easily accept a couple hundred words so it would be nice to see that easier in a text area.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @phonghpham! Just one comment re textarea.
@phonghpham we just merged a long awaited PR on authorization. Could you please add an auth check to the controller actions (and probably need to add a permission in the arrays of permissions for this activity for staff, and admin)? Let me know if you need any help doing so. Most other controllers have it implemeneted, now, for examples. |
c1109a3
to
79e6b19
Compare
@phonghpham, if you have any issues implementing the authz, feel free to ask here or @ me on Slack. |
5fd2836
to
c823557
Compare
@kasugaijin , @mononoken, apologies for teh delay, this is ready for re-review |
c823557
to
19a4b56
Compare
In prod code, when organization is created, an associated page text is created for it.
19a4b56
to
7074ef3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates! @phonghpham
🔗 Issue
Resolves #479 #480
✍️ Description
This PR adds ability for staff admin to update org page text.
📷 Screenshots/Demos