Create AdopterFosterAccount

[ErinClaudio]

🔗 Issue

#449

✍️ Description

📷 Screenshots/Demos

[ErinClaudio]

@kasugaijin

Please review and let me know if this approach seems appropriate.

This adjustment involved only altering the model name, so I updated the wording in the model files accordingly while keeping the relationships unchanged.

Planned Steps:

1. Rename AdopterAccount to AdopterFosterAccount across the entire application.
2. This renaming will necessitate a series of migrations. Execute these migrations and address any resulting errors.
3. Ideally, all tests should pass after these changes. If not, we will tackle the failing tests next.

Let me know your thoughts.

[ErinClaudio]

notes

[kasugaijin]

Yes your steps seem appropriate. I have left a series of comments. One thing, while you have started a new branch, it looks like you have not reset your database and you have committed schema changes from the old PR where we were going to use polymorphic association. Note that your database, unless you create a new one for a separate branch, or recreate it entirely, will still have the schema from whatever migrations you have run on it. In this case, it has the changes from the migrations in the old PR. So please drop and recreate your db, paying a mind to which migrations you have in this branch, and ensure you only have the migrations from main branch + whatever you need for this PR. That will re-write the schema and remove the unwanted changes we have above. Thanks!

[ErinClaudio]

@kasugaijin I hope I've left this ticket in a decent spot for you. The schema should now reflect the correct changes. The next steps involve updating the seed file and modifying all instances of the adopter_accounts.

[kasugaijin]

@kasugaijin I hope I've left this ticket in a decent spot for you. The schema should now reflect the correct changes. The next steps involve updating the seed file and modifying all instances of the adopter_accounts.

Thanks @ErinClaudio! You did most of the work. Just two quick commits after.

[nsiwnf]

Great job! Would it be possible to combine all the migrations into one migration file? I think we can also rename columns which would help retain data

[kasugaijin]

Great job! Would it be possible to combine all the migrations into one migration file? I think we can also rename columns which would help retain data

Done. I split the table rename and column renames into two migration files. I also added foreign key constraints for the belong_to relationships.

[mononoken]

lgtm! I think we should update the authorization permission names to reflect the AdopterProfile to AdopterFosterProfile name change, but I can do that in a separate PR once this is merged.

Thank you for all the work, Erin!

[kasugaijin]

lgtm! I think we should update the authorization permission names to reflect the AdopterProfile to AdopterFosterProfile name change, but I can do that in a separate PR once this is merged.

Thank you for all the work, Erin!

Good point! This branch needs main merging in and then running find and replace again. I can do that.

[kasugaijin]

@mononoken I made changes to policy permission names (commit below) and added unique constraint to the index as suggested.

FYI I am finishing this off for Erin as he is away for 10 days - @ErinClaudio is aware I was taking over :)

[mononoken]

@mononoken I made changes to policy permission names (commit below) and added unique constraint to the index as suggested.

FYI I am finishing this off for Erin as he is away for 10 days - @ErinClaudio is aware I was taking over :)

Thanks for taking over, @kasugaijin ! The new changes look good.

[kasugaijin]

@mononoken I made changes to policy permission names (commit below) and added unique constraint to the index as suggested.
FYI I am finishing this off for Erin as he is away for 10 days - @ErinClaudio is aware I was taking over :)

Thanks for taking over, @kasugaijin ! The new changes look good.

@mononoken feel free to approve and merge if you want to!

[kasugaijin]

Nice! This unblocks a lot of work!