Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

503 org root part2 hero #504

Merged
merged 13 commits into from
Mar 8, 2024

Conversation

Developer3027
Copy link
Contributor

🔗 Issue

issue 503

✍️ Description

Update the Hero section to v2.

📷 Screenshots/Demos

Screenshot from 2024-03-07 20-14-32
Screenshot from 2024-03-07 20-14-20

@Developer3027
Copy link
Contributor Author

Note - The background image here is linked url from the figma file. This should be local? Not sure if I am getting a good copy via my download from guest figma.

@kasugaijin
Copy link
Collaborator

Note - The background image here is linked url from the figma file. This should be local? Not sure if I am getting a good copy via my download from guest figma.
Yes ideally we serve the Hero image as an asset, but for now this is fine. We may also allow orgs to upload their own image for this...so more to be done here later.

Copy link
Collaborator

@kasugaijin kasugaijin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@kasugaijin kasugaijin merged commit 3aa9726 into rubyforgood:main Mar 8, 2024
3 checks passed
@Developer3027 Developer3027 deleted the 503-org-root-part2-hero branch March 27, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants