473 create page text #476
Merged
473 create page text #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion is created, and add test
|
It looks like this failed on the one still flaky test. Is there a way I can rerun it? |
|
@MooseCowBear done! Will review when I get some time this week :) |
kasugaijin
approved these changes
Feb 29, 2024
ErinClaudio
pushed a commit
that referenced
this pull request
Mar 1, 2024
* add PageTexts model, table * update factory, add validations and validation tests * update seed files to create page text for organization * add dependent destroy to page text association * add association test for page text * update organizations create service to create page text when organization is created, and add test
ErinClaudio
pushed a commit
that referenced
this pull request
Mar 1, 2024
* add PageTexts model, table * update factory, add validations and validation tests * update seed files to create page text for organization * add dependent destroy to page text association * add association test for page text * update organizations create service to create page text when organization is created, and add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue
#473
✍️ Description
Adds a
PageTextmodel withorganization_id,about, andherocolumns, with index.aboutandheroallow nil but not empty strings or strings containing only whitespace.Updates create service object to create a page_text for organization, and seed files.
Adds factory, tests for new model.
📷 Screenshots/Demos