Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

430 Update application reviews/notes with turbo_stream #447

Merged

Conversation

jmilljr24
Copy link
Collaborator

Resolves #430

✍️ Description

-Add turbo_stream response to adoption_application_reviews_controller
-Add notes update with modal
-Add change status with dropdown
-Update tests

📷 Screenshots/Demos

Screencast.from.01-24-2024.06.30.36.PM.webm

-Add turbo_stream response to adoption_application_reviews_controller
-Add notes update with modal
-Add change status with dropdown
-Update tests
@jmilljr24 jmilljr24 closed this Jan 25, 2024
@jmilljr24 jmilljr24 reopened this Jan 25, 2024
@kasugaijin
Copy link
Collaborator

@jmilljr24 this is so cool! Awesome work. The code looks good. I cannot run it on this machine, but I suspect you can do the same as you showed in your gif, but on the pet/applications tab also?

@jmilljr24
Copy link
Collaborator Author

@jmilljr24 this is so cool! Awesome work. The code looks good. I cannot run it on this machine, but I suspect you can do the same as you showed in your gif, but on the pet/applications tab also?

Thanks! Yes everything works on the pet/application tab as well. I added a little code to shorten the truncate of the notes because that table is smaller. I'm sure with a small enough screen/breakpoint there will be issues with the size of the table but I didn't want to change too much with it. I would think there would need to be discussion on the UX/UI for that.

Screencast.from.01-25-2024.06.14.04.PM.webm

@kasugaijin
Copy link
Collaborator

Ok great @jmilljr24 I will shoot the gif of the pet tab to Trisha who is doing UX. My hunch is we can remove the text if it's in the pet tab and just have a link to edit or something. I don't think that needs to hold this PR up but something she should see.

@kasugaijin
Copy link
Collaborator

@all-contributors
Please add @atbalaji for code.

Copy link
Contributor

@kasugaijin

I've put up a pull request to add @atbalaji! 🎉

Copy link
Collaborator

@kasugaijin kasugaijin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kasugaijin kasugaijin merged commit 26ece0c into rubyforgood:main Jan 26, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View "notes" column in the applications tables
2 participants