410 admin can toggle to disable staff #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add test for controller action
…a boolean value, add tests for method
…table to add deactivate column with toggle and remove status column
|
Yes please do change the method name to something more applicable ...something like |
|
Merge conflict FYI. |
nsiwnf
requested changes
Jan 10, 2024
|
Whoops. Okay should be good now. |
nsiwnf
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue
#410
✍️ Description
Adds a deactivate column with a toggle to staff index page with turbo stream response and removes the status column. Removes the verified column from the staff accounts table, replaces references to it with a check for nil in the deactivated_at column, and removes mentions of needing to be verified from email templates. Also updates factories and tests to reflect the change.
I didn't rename the verified_staff method in the application controller, but it might be more accurate to say active staff now. If you want, I can change that too.
📷 Screenshots/Demos