355 filtering adopter applications #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phonghpham
force-pushed
the
355-filtering-adopter-applications
branch
3 times, most recently
from
dc99314 to
7b8ab9c
Compare
|
This looks great! Unless someone beats me to it, I will review this later this week. |
phonghpham
force-pushed
the
355-filtering-adopter-applications
branch
from
12a46de to
3dca156
Compare
|
I played around and the search looks good. Also, is this happening for you? If I go to a pet, none of the tabs are rendering. Have you merged main branch in? I don't think I see it in your commits. That might fix it. There should be partials rendered here for each tab...none rendering. |
but rather as local var passed in from search results partial. Since applications is also passed from search results partial, use that.
by integrating Ransack into index. - Update @Pets variable to better reflect data being handled
filtering on applicant name
…her associated applications
…ppear in response body as options
filtering still work. Tested this locally, and without this seemingly superfluous check, only application status can be filtered.
phonghpham
force-pushed
the
355-filtering-adopter-applications
branch
from
84f3247 to
4567e77
Compare
|
@kasugaijin, you're right, after I rebased off main and made a tweak all tabs are now rendering in pet show view. Tests passing locally and updated Applications to reflect pet name. |
kasugaijin
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue
resolves #355
✍️ Description
Allow staff to filter adopter applications by pet name, applicant name, and application status.
📷 Screenshots/Demos
Alta.Pet.Rescue._._Pet.Rescue_.-.16.December.2023.mp4