Fix pets form field hints, asterisk, validations #260
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue
#244
✍️ Description
I moved the field hints below inputs for an improved appearance and removed the extra asterisk that remained in sign up page. I also removed the old validation errors in favor of the bootstrap_form validation errors, however it dawned on me that the other forms all still have hardcoded validation error messages. I'm not sure if that warrants a new issue, or how we wanted to handle that.
For the record, if we want to continue to write our own custom validation error messages, bootstrap_form offers options for handling validations and errors like disabling automatic inline errors. I just assumed we wanted to let bootstrap_form handle this as well, so please let me know if I'm wrong.
📷 Screenshots/Demos
With old error validations
Removed old error validations leaving only bootstrap_form errors