Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pets form field hints, asterisk, validations #260

Merged
merged 3 commits into from
Oct 14, 2023

Conversation

reyes-dev
Copy link
Contributor

🔗 Issue

#244

✍️ Description

I moved the field hints below inputs for an improved appearance and removed the extra asterisk that remained in sign up page. I also removed the old validation errors in favor of the bootstrap_form validation errors, however it dawned on me that the other forms all still have hardcoded validation error messages. I'm not sure if that warrants a new issue, or how we wanted to handle that.

For the record, if we want to continue to write our own custom validation error messages, bootstrap_form offers options for handling validations and errors like disabling automatic inline errors. I just assumed we wanted to let bootstrap_form handle this as well, so please let me know if I'm wrong.

📷 Screenshots/Demos

With old error validations
old_form_validations
Removed old error validations leaving only bootstrap_form errors
removed_old_form_validations

Copy link
Collaborator

@kasugaijin kasugaijin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Yes other forms will eventually need updating. However, I think it's best we wait until we have built those respective features out as things might change. I think we can let bootstrap form handle the errors for now.

@kasugaijin
Copy link
Collaborator

@all-contributors
please add @reyes-dev for code.

@allcontributors
Copy link
Contributor

@kasugaijin

I've put up a pull request to add @reyes-dev! 🎉

@kasugaijin kasugaijin merged commit 60042a7 into rubyforgood:main Oct 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants