Add species to pets table and set up enum in the pet model #233
Conversation
jadekstewart3
requested review from
edwinthinks,
kasugaijin,
marlena-b and
nsiwnf
and removed request for
marlena-b
| @@ -0,0 +1,5 @@ | |||
| class AddSpecies2Pets < ActiveRecord::Migration[7.0] | |||
| def change | |||
| add_column :pets, :species, :integer | |||
There was a problem hiding this comment.
| add_column :pets, :species, :integer | |
| add_column :pets, :species, :integer, null: false |
Adding this null: false prevents at the database level from allowing rows without the species defined. Helps keep data more accurate in case of issues. This comes especially helpful if validations get skipped
There was a problem hiding this comment.
@jadekstewart3 in case you missed this comment :)
There was a problem hiding this comment.
@edwinthinks I totally did! Thank you, I'll get that updated:)
There was a problem hiding this comment.
@jadekstewart3 I think the schema.rb file was not updated with null: false. Easiest way to regenerate it is to run rails db:rollback and rails db:migrate :)
There was a problem hiding this comment.
@Ptrboro Oh heck! Thank you!
| @@ -31,6 +31,7 @@ class Pet < ApplicationRecord | |||
| has_many :adopter_applications, dependent: :destroy | |||
| has_one :match, dependent: :destroy | |||
| has_many_attached :images | |||
| enum species: ["dog", "cat"] | |||
There was a problem hiding this comment.
Let's add quick test for this using shoulda - https://matchers.shoulda.io/docs/v3.1.1/Shoulda/Matchers/ActiveRecord.html#define_enum_for-instance_method
🔗 Issue
#222
✍️ Description
Added species column to pets table, and setup species enum within the pets model.
📷 Screenshots/Demos