228 remove location columns on organizations table and add zipcode to locations table #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuricarvalhop
commented
Oct 3, 2023
ErinClaudio
pushed a commit
that referenced
this pull request
Oct 3, 2023
… locations table (#230) * Remove location fields to Organization * Add zipcode field to locations * Fix seeds * Add zipcode to location factory * WIP: Remove organization.city usage from views/organizations/home/index.html.erb * Run automatic fixer * Remove unecessary comment
yuricarvalhop
deleted the
228-remove-location-columns-on-organizations-table-and-add-zipcode-to-locations-table
branch
ErinClaudio
pushed a commit
that referenced
this pull request
Oct 5, 2023
… locations table (#230) * Remove location fields to Organization * Add zipcode field to locations * Fix seeds * Add zipcode to location factory * WIP: Remove organization.city usage from views/organizations/home/index.html.erb * Run automatic fixer * Remove unecessary comment
edwinthinks
added a commit
that referenced
this pull request
Oct 6, 2023
…ick (#198) * Update with recent changes to main * Update with debugging * Update singout works I still need to clean up messy code * Pets index styling (#204) * added layout import to pets dashboard, removed javascript from head partial * utilize geeks ui styling and move components * Implement requested changes * Change header variable to match others * remove previous change that was causing funky formatting * Add closing tag * Sticky nav bar (#217) * Updating index page to match geekui styling * Update pet show screen to match geeksui mock * Adding staff index page (#223) Co-authored-by: Edwin Mak <[email protected]> * Invert association between Location and AdopterProfile (#225) * Added the gretel gem to manage breadcrumbs. Added breadcrubms to dashboard pets index and show * 228 remove location columns on organizations table and add zipcode to locations table (#230) * Remove location fields to Organization * Add zipcode field to locations * Fix seeds * Add zipcode to location factory * WIP: Remove organization.city usage from views/organizations/home/index.html.erb * Run automatic fixer * Remove unecessary comment * Update with debugging code removed * Increase process timeout in tests (#237) * Fix flaky test by increasing process_timeout * Fix deprecation warning by bumping city-state gem * Created a partial for pet_card and updated the design (#239) * Form for adding staff (#224) * Saving staff separately - some issues with saving role as a nested attribute Co-authored-by: Edwin Mak <[email protected]> * Updated links in the new adoption application mail erb template (#238) * Fix flash messages on the dashboard (#236) * Update merge files * Sticky nav bar (#217) * Updating index page to match geekui styling * Update pet show screen to match geeksui mock * Adding staff index page (#223) Co-authored-by: Edwin Mak <[email protected]> * Invert association between Location and AdopterProfile (#225) * Added the gretel gem to manage breadcrumbs. Added breadcrubms to dashboard pets index and show * 228 remove location columns on organizations table and add zipcode to locations table (#230) * Remove location fields to Organization * Add zipcode field to locations * Fix seeds * Add zipcode to location factory * WIP: Remove organization.city usage from views/organizations/home/index.html.erb * Run automatic fixer * Remove unecessary comment * Added happy path test * Update with pseudocodefor tests * Update testing merge conflicts * Update with git merge main * Update alta seed file fixed * Update new line added * Update to schema * Update to merging/rebase issues * Correct syntax for button_to with do end added * Syntax cleanup * Update with sad path test * Update with improved test * Update with hardcoded page for testing * Update with local passing tests that fail on CI * Update with hard coded route * Update org slug --------- Co-authored-by: Jade Stewart <[email protected]> Co-authored-by: Sree P <[email protected]> Co-authored-by: Sree P <[email protected]> Co-authored-by: Edwin Mak <[email protected]> Co-authored-by: Marlena Borowiec <[email protected]> Co-authored-by: Alvaro Sanchez <[email protected]> Co-authored-by: Yuri Pains <[email protected]> Co-authored-by: Piotr Borowiec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue
#228
✍️ Description
Removing following fields from Organization:
Adding following field to Location
📷 Screenshots/Demos