Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Navbar Links #197

Merged
merged 15 commits into from
Sep 28, 2023
Merged

Update Navbar Links #197

merged 15 commits into from
Sep 28, 2023

Conversation

kasugaijin
Copy link
Collaborator

@kasugaijin kasugaijin commented Sep 26, 2023

… because the text was hidden and this made it appear. Some more tinkering required to fix the position

Describe your change in plain English.

I added new links to the navbar.
In this process I had to create some new controllers and views. I decided to scope all relevant controller and views under Organization (including existing ones that were not, as it had to be done eventually).

To do:

  • update broken tests to fix the url paths than have changed after scoping stuff under Organizations.

Note: the UI is a bit broken. Edwin is looking into fixing the scrollbar issues surrounding the links.

image

Link to the issue

@kasugaijin kasugaijin changed the title add links to navbar. Note I removed class navbar from the nav element… Update Navbar Links Sep 27, 2023
@edwinthinks
Copy link
Collaborator

Hey @kasugaijin I just updated with main with the fixed test. I'll review this now :)

Copy link
Collaborator

@edwinthinks edwinthinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. Once the tests are passing or you decide to skip them, feel free to merge in!

This is exciting!

@kasugaijin kasugaijin merged commit c4013d8 into main Sep 28, 2023
@kasugaijin kasugaijin deleted the 192-navbar-links branch September 28, 2023 01:27
@kasugaijin kasugaijin mentioned this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants