-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Navbar Links #197
Merged
Merged
Update Navbar Links #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… because the text was hidden and this made it appear. Some more tinkering required to fix the position
…w, routes under organization.
kasugaijin
changed the title
add links to navbar. Note I removed class navbar from the nav element…
Update Navbar Links
Sep 27, 2023
Hey @kasugaijin I just updated with main with the fixed test. I'll review this now :) |
edwinthinks
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment. Once the tests are passing or you decide to skip them, feel free to merge in!
This is exciting!
app/controllers/organizations/foster_application_reviews_controller.rb
Outdated
Show resolved
Hide resolved
edwinthinks
reviewed
Sep 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… because the text was hidden and this made it appear. Some more tinkering required to fix the position
Describe your change in plain English.
I added new links to the navbar.
In this process I had to create some new controllers and views. I decided to scope all relevant controller and views under Organization (including existing ones that were not, as it had to be done eventually).
To do:
Note: the UI is a bit broken. Edwin is looking into fixing the scrollbar issues surrounding the links.
Link to the issue