Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error message when login does not work #189

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

edwinthinks
Copy link
Collaborator

@edwinthinks edwinthinks commented Sep 25, 2023

Describe your change in plain English.

This handles the issue in #185 in which we want to inform users when their username/password is incorrect.

Demo

Captura de pantalla 2023-09-25 a las 18 17 07

Link to the issue

#185

Copy link
Collaborator

@kasugaijin kasugaijin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edwinthinks edwinthinks merged commit dfccfc9 into main Sep 27, 2023
@edwinthinks edwinthinks deleted the edwin/185/devise-error-feedback branch September 27, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants