Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique species scope and test #1306

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Yuji3000
Copy link
Contributor

@Yuji3000 Yuji3000 commented Dec 28, 2024

🔗 Issue

#1081 Issue Link

✍️ Description

Added scope "unique_species" of an ORG for future conditional rendering of species buttons. Simple test also added to make sure a single species isn't returned more than once.

Directions said to continue to show all species, and what I understand was talks about future implementation. So I didn't go any further. If I misunderstood, let me know.

📷 Screenshots/Demos

Screenshot 2024-12-27 at 7 39 03 PM Screenshot 2024-12-27 at 7 38 47 PM

@Yuji3000 Yuji3000 marked this pull request as draft December 28, 2024 02:48
@kasugaijin
Copy link
Collaborator

kasugaijin commented Dec 28, 2024

@Yuji3000 I see it's still draft so forgive me if I am stating something you intend to work on. This scope looks good. Now we should use this in places where we show the 'See {species}' buttons e.g., the org home page hero section. We should render a button (that sends the correct species param to the controller) for each unique species.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants