Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1180: Add new images to app root page #1305

Merged
merged 5 commits into from
Dec 29, 2024
Merged

Issue #1180: Add new images to app root page #1305

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e7810c8
initial commit
jasonwang7517 Dec 28, 2024
07debd7
correcting a whole bunch of silly mistakes
jasonwang7517 Dec 28, 2024
41fa8b9
Merge branch 'main' into 1180-add-new-images
jasonwang7517 Dec 28, 2024
17e57a7
removing outer divs
jasonwang7517 Dec 28, 2024
eb27a72
Merge branch '1180-add-new-images' of https://github.com/jasonwang751…
jasonwang7517 Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added app/assets/images/adoption_applications.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added app/assets/images/invite_fosterers.png
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is a little fatter since when it's set to the same ratio as the other pictures, we get the card view which is full of "coming soon" pictures. Not sure if that matters a ton but I thought it was worth pointing out.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now! Better than the placeholder image we had.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added app/assets/images/invite_staff.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
16 changes: 8 additions & 8 deletions app/views/root/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
</div>
</div>
<div class = "col-lg-6 col-md-12 col-12">
<div class = "mb-4 mb-lg-0 bg-gray-200 rounded-4">
<div class = "mb-4 mb-lg-0 rounded-4 p-4 shadow-lg">
<%= image_tag "layout_graphic.png", alt: "screen_1", class: "img-fluid w-100 h-75"%>
</div>
</div>
Expand All @@ -126,7 +126,7 @@
</div>
</div>
<div class = "col-lg-6 col-md-12 col-12">
<div class = "mb-4 mb-lg-0 bg-gray-200 rounded-4">
<div class = "mb-4 mb-lg-0 rounded-4 p-4 shadow-lg">
<%= image_tag "layout_graphic_2.png", alt: "screen_2", class: "img-fluid w-100 h-75"%>
</div>
</div>
Expand Down Expand Up @@ -193,8 +193,8 @@
</div>
</div>
<div class = "col-lg-6 col-md-12 col-12">
<div class = "mb-4 mb-lg-0 bg-gray-200 rounded-4">
<%= image_tag "layout_graphic_3.png", alt: "screen_3", class: "img-fluid w-100 h-75"%>
<div class = "mb-4 mb-lg-0 rounded-4 p-4 shadow-lg">
<%= image_tag "invite_fosterers.png", alt: "screen_3", class: "img-fluid w-100 h-75"%>
</div>
</div>
</div>
Expand All @@ -211,8 +211,8 @@
</div>
</div>
<div class = "col-lg-6 col-md-12 col-12">
<div class = "mb-4 mb-lg-0 bg-gray-200 rounded-4">
<%= image_tag "layout_graphic_3.png", alt: "screen_3", class: "img-fluid w-100 h-75"%>
<div class = "mb-4 mb-lg-0 rounded-4 p-4 shadow-lg">
<%= image_tag "invite_staff.png", alt: "screen_3", class: "img-fluid w-100 h-75 rounded"%>
</div>
</div>
<div class = "col-lg-6 col-md-12 col-12 mt-4 mt-lg-0 d-none d-md-block">
Expand Down Expand Up @@ -277,8 +277,8 @@
</div>
</div>
<div class = "col-lg-6 col-md-12 col-12">
<div class = "mb-4 mb-lg-0 bg-gray-200 rounded-4">
<%= image_tag "layout_graphic_2.png", alt: "hero", class: "img-fluid w-100 h-75"%>
<div class = "mb-4 mb-lg-0 rounded-4 p-4 shadow-lg">
<%= image_tag "adoption_applications.png", alt: "hero", class: "img-fluid w-100 h-75"%>
</div>
</div>
</div>
Expand Down
Loading