Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve design of the Foster Invite form using vertical form inputs #1301

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

edwinthinks
Copy link
Collaborator

🔗 Issue

#1288

✍️ Description

Clean up some stylings while making some design decisions along the way. One thing I decided to try out was to put all input fields in the same column rather than trying to split them. I've been told that it is best practice for design to not do two column forms. The reasoning to me makes sense, you don't want to change a person's context when reading from left to right and downwards. This also solves the problem with handling mobile mode as it already is stacked on top of each other.

I recommend sticking to this pattern since there will less work figuring out what the next styling should be. My rule of thumb is stick to the vertical forms until it breaks and you need to introduce something else more unique.

📷 Screenshots/Demos

Desktop:
CleanShot 2024-12-25 at 12 58 22@2x

Mobile:

CleanShot 2024-12-25 at 12 58 31@2x

@edwinthinks edwinthinks changed the title Clean up styling a bit Improve design of the Foster Invite form using vertical form inputs Dec 25, 2024
Copy link
Collaborator

@kasugaijin kasugaijin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edwinthinks ah yes single column is great. I agree we should stick to this. It makes sense based on your rationale.

@kasugaijin kasugaijin merged commit 444515d into main Dec 25, 2024
5 checks passed
@kasugaijin kasugaijin deleted the edwin/1288/fix-input-layout branch December 25, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants