Some more small fixes #1283
Merged
Some more small fixes #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmilljr24
approved these changes
Dec 19, 2024
| @@ -26,7 +26,7 @@ | |||
| </div> | |||
| <div class="form-group"> | |||
| <%= f.label :sex_eq, "Sex" %> | |||
| <%= f.select :sex_eq, ["Male", "Female"], {include_blank: 'All'}, class: "form-select" %> | |||
| <%= f.select :sex_eq, [["Male", "male"], ["Female", "female"]], {include_blank: 'All'}, class: "form-select" %> | |||
There was a problem hiding this comment.
This is fine for now. The create pet form just gives a drop down so we really should only have downcase. I'm guessing the issue stemmed from seed data. We could a maybe add a before_save to the model.
There was a problem hiding this comment.
The pet create form will save a downcase sex, but the ransack filter was using capitalized sex. I think a better approach would be to just use an enum instead of a string for the sex attribute. That should get rid of the case issue for good. I'll add a to do in the project for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue
Fixes bugs found by @mgrigoriev8109 here
✍️ Description
📷 Screenshots/Demos