Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor countries states #1278

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Refactor countries states #1278

merged 3 commits into from
Dec 18, 2024

Conversation

kasugaijin
Copy link
Collaborator

@kasugaijin kasugaijin commented Dec 18, 2024

🔗 Issue

Try and access the staff > org settings form and you will get an error related to CS module. I think it might be a naming interference in this scope between the CS constant that contains the countries and states, and a CS module. I have updated to use a more descriptive (unique) constant name to solve the issue.

✍️ Description

📷 Screenshots/Demos

…le name was breaking in the Org settings context (might interfere with an existing name)
Copy link
Collaborator

@jmilljr24 jmilljr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmilljr24 jmilljr24 merged commit 9245063 into main Dec 18, 2024
5 checks passed
@jmilljr24 jmilljr24 deleted the fix-org-settings-location branch December 18, 2024 23:37
Copy link
Collaborator

@maebeale maebeale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants