Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tooltip to awaiting data status for new adopters #1269

Merged
merged 7 commits into from
Dec 19, 2024

Conversation

jasonwang7517
Copy link
Contributor

@jasonwang7517 jasonwang7517 commented Dec 17, 2024

🔗 Issue

1228: Add tooltip to the awaiting data status for adopters

✍️ Description

Adds a new tooltip when adopters have submitted applications but have not yet had a questionnaire reviewed by staff.

📷 Screenshots/Demos

image

@kasugaijin
Copy link
Collaborator

@jasonwang7517 thanks for your back and forth on this. We decided on our call this evening to just keep it super simple for MVP. Instead of adding the tooltip with custom JS, could you please just add the text in a paragraph underneath the status? We will just show the plain text at all times instead. We could add this in a card to make it look nicer (see the empty state parial for an example). Does this make sense?

@jasonwang7517
Copy link
Contributor Author

@jasonwang7517 thanks for your back and forth on this. We decided on our call this evening to just keep it super simple for MVP. Instead of adding the tooltip with custom JS, could you please just add the text in a paragraph underneath the status? We will just show the plain text at all times instead. We could add this in a card to make it look nicer (see the empty state parial for an example). Does this make sense?

Got it!

@jasonwang7517 jasonwang7517 force-pushed the 1228-awaiting-data-tooltip branch from 8c06978 to 2bd33a8 Compare December 18, 2024 08:02
@jasonwang7517
Copy link
Contributor Author

@jasonwang7517 thanks for your back and forth on this. We decided on our call this evening to just keep it super simple for MVP. Instead of adding the tooltip with custom JS, could you please just add the text in a paragraph underneath the status? We will just show the plain text at all times instead. We could add this in a card to make it look nicer (see the empty state parial for an example). Does this make sense?

I wasn't sure if by "at all times" you meant no matter what the status was so I kept it under an awaiting_review check but I can take that out if we truly want it for any application status!

@kasugaijin
Copy link
Collaborator

kasugaijin commented Dec 18, 2024

@jasonwang7517 thanks for your back and forth on this. We decided on our call this evening to just keep it super simple for MVP. Instead of adding the tooltip with custom JS, could you please just add the text in a paragraph underneath the status? We will just show the plain text at all times instead. We could add this in a card to make it look nicer (see the empty state parial for an example). Does this make sense?

I wasn't sure if by "at all times" you meant no matter what the status was so I kept it under an awaiting_review check but I can take that out if we truly want it for any application status!

It just needs to show when the status is awaiting_data :)
The reason is that this means either the adopter has not filled out their form, or they have, but staff have not yet uploaded the latest form responses. You can replicate this by signing up as a new adopter (and skip the form after sign up) and submitting an application on a pet

@kasugaijin kasugaijin merged commit 140adf0 into rubyforgood:main Dec 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants