Add solid cable and solid queue #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmilljr24
commented
Dec 16, 2024
| @@ -91,10 +104,18 @@ test: | |||
| # for a full overview on how database connection configuration can be specified. | |||
| # | |||
| production: | |||
| <<: *default | |||
| host: <%= ENV["DB_HOST"] %> | |||
| pool: 5 | |||
There was a problem hiding this comment.
Default is 5. No need to define here.
jmilljr24
commented
Dec 16, 2024
| @@ -55,9 +55,6 @@ | |||
| config.assume_ssl = true | |||
| config.force_ssl = true | |||
|
|
|||
| # Include generic and useful information about system operation, but avoid logging too much | |||
| # information to avoid inadvertent exposure of personally identifiable information (PII). | |||
| config.log_level = :info | |||
There was a problem hiding this comment.
Missed this in rails 8 upgrade. defined twice.
kasugaijin
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Nice. It's nice not to have to use Redis when you don't have to.
@jmilljr24 can you please link to the resources you followed to implement this in the description? I am assuming it's the rails guides...but maybe others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue
✍️ Description
Solid Cable is a database-backed Action Cable (websockets) adapter. Removes the need for something like Redis.
Solid Queue is a DB-based queuing backend for Active Job. This will allow us to add background jobs.
A few minor fixes were also added.
References:
https://github.com/rails/solid_cable
https://github.com/rails/solid_queue
📷 Screenshots/Demos