CSV Import - correctly report validation error for timestamp #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasugaijin
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Should we remove the validation for csv_timestamp on FormSubmission with this now? Alternatively, we could use a dummy value, but given it's datetime I am not sure how useful this might be.
EDIT: Oh nevermind...we want to show the error per your screenshot and enforce that header. Ok, I prefer this for now. We can test this with users and see if we need to handle anything differently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue
✍️ Description
The validation error is correctly returned now. I also fixed the row index. Headers are skipped so the count was off by one.
📷 Screenshots/Demos