Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopter fosterer form answers #1256

Merged
merged 38 commits into from
Dec 16, 2024
Merged

Adopter fosterer form answers #1256

merged 38 commits into from
Dec 16, 2024

Conversation

kasugaijin
Copy link
Collaborator

@kasugaijin kasugaijin commented Dec 15, 2024

🔗 Issue

#1248
Adds ability for adtopers and fosterers to see their latest form submission's form answers so they can review it for accuracy.
adopter-fosterer-form-answers

✍️ Description

📷 Screenshots/Demos

…bmitted at in case someone submits a form twice in one day, then it is easiser to determine which answers you are looking at
@kasugaijin kasugaijin changed the base branch from main to form-submission-refactor December 15, 2024 04:45
@kasugaijin kasugaijin marked this pull request as ready for review December 15, 2024 04:49
@kasugaijin kasugaijin marked this pull request as draft December 15, 2024 04:51
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the form answers to a partial that can be user here and in the staff review of form answers. Do this once base branch is merged.

config/routes.rb Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-arranged the routes file as it was getting ugly. Not directly related to this feature but sorely needed. I doubled checked to ensure I did not inadvertantly delete any routes. I did delete those that were no longer needed related to profile (the old adopter profile)

Base automatically changed from form-submission-refactor to main December 15, 2024 16:11
@@ -0,0 +1,24 @@
module Organizations
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided we only need to show the latest form answers (form submission) to adopters and fosterers. They just need to validate accuracy of the current 'snapshot' of data and don't need to see prior submissions.

@kasugaijin kasugaijin marked this pull request as ready for review December 15, 2024 22:12
Copy link
Collaborator

@jmilljr24 jmilljr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kasugaijin lgtm!

@kasugaijin kasugaijin merged commit dbcbeee into main Dec 16, 2024
5 checks passed
@kasugaijin kasugaijin deleted the adopter-fosterer-form-answers branch December 16, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants