Implement a reusable empty state partial for all places that need them #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jp524 cool I will take a look tomorrow! FYI - some conflicts now we merged some stuff :) |
kasugaijin
reviewed
Dec 16, 2024
app/views/organizations/staff/adoption_application_reviews/_search_results.html.erb
Show resolved
Hide resolved
kasugaijin
reviewed
Dec 16, 2024
kasugaijin
reviewed
Dec 16, 2024
kasugaijin
reviewed
Dec 16, 2024
There was a problem hiding this comment.
Looks great @jp524
Just one comment, and a merge conflict (we have been merging a lot recently)
kasugaijin
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue
Resolves #1224.
✍️ Description
Modified all relevant views to use the new
empty_statepartial. I liked the look of the existing card in/adoptable_petsso I decided to reuse that in the partial.📷 Screenshots/Demos
Here's a sample of views using the new partial:
staff > pet > photos
staff > foster pets
adopter fosterer > adopted pets
adoptable pets
