Rails 8 #1241
Merged
Rails 8 #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmilljr24
commented
Dec 11, 2024
jmilljr24
commented
Dec 11, 2024
kasugaijin
reviewed
Dec 13, 2024
kasugaijin
reviewed
Dec 13, 2024
app/controllers/organizations/staff/custom_form/questions_controller.rb
Outdated
Show resolved
Hide resolved
kasugaijin
approved these changes
Dec 15, 2024
There was a problem hiding this comment.
Awesome! Thanks for taking care of this @jmilljr24
I will let you merge this. If you have time, can you please do a manual deploy and check nothing explodes in production?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue
✍️ Description
Upgrade to Rails 8. I attempted to keep any new rails 8 defaults unless we had something configured differently. I also changed the annotate gem to annotaterb as it supports rails 8 and the previous seems to be abandoned.
I did some user flows and fixed anything minor that I came across. Please verify the docker development setup works.
📷 Screenshots/Demos