Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partner and about us; force footer to stick to the bottom #1237

Merged
merged 8 commits into from
Dec 11, 2024

Conversation

kasugaijin
Copy link
Collaborator

@kasugaijin kasugaijin commented Dec 10, 2024

✍️ Description

Adds an About page on the app root.
Adds a Partners page on app root. Bugsnag require featuring here as part of giving us a free plan.
Refactors the value add section on the app route.

I also tweaked the app root top nav links to be the same colour on and off focus. I also forced the footer to stick to the bottom of the page as it would float up if there was not enough content to push it down.

image image image image

📷 Screenshots/Demos

@kasugaijin kasugaijin requested a review from jmilljr24 December 10, 2024 19:33
@kasugaijin kasugaijin requested a review from mononoken December 10, 2024 21:05
Copy link
Collaborator

@mononoken mononoken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep the html5 doctype declaration but otherwise lgtm with a few other small comments.

app/views/static_pages/partners.html.erb Outdated Show resolved Hide resolved
app/views/static_pages/partners.html.erb Outdated Show resolved Hide resolved
app/views/static_pages/partners.html.erb Outdated Show resolved Hide resolved
config/locales/en.yml Show resolved Hide resolved
app/views/layouts/application.html.erb Show resolved Hide resolved
@kasugaijin kasugaijin merged commit 16f5fae into main Dec 11, 2024
5 checks passed
@kasugaijin kasugaijin deleted the about-and-partners branch December 11, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants