Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1180 - App root page - add new images #1199

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Aaryanpal
Copy link
Contributor

updated screenshot in root page

🔗 Issue

#1180

✍️ Description

Added New Screenshot for the application
Browser Resolution=> 1205x900
Screenshot edit by Screenzy
Compress by => tinypng

📷 Screenshots/Demos

Desktop

Screencast.from.2024-11-30.16-24-53.webm

Mobile

Screencast.from.2024-11-30.16-26-31.webm

updated screenshot in root page
@jmilljr24
Copy link
Collaborator

@Aaryanpal Thanks for working on this!

I noticed the grey border looked quite a bit difference for the sections you updated vs. the untouched one and it got me thinking.

I decided to take a look at the figma file and it appears we drifted away from the design prior to this commit. The figma design shows just the image with a shadow applied. @kasugaijin should we correct this back to match the figma design or did I miss some decisions to alter this to include the grey border? (my vote is original figma design)


untouched
Screenshot from 2024-11-30 14-04-40


pr change
Screenshot from 2024-11-30 13-58-58


[figma](https://www.figma.com/design/0jVgYASUJy0KiX3BVc3dFM/Tasks?node-id=1150-254&node-type=frame)

Screenshot from 2024-11-30 13-57-18

@kasugaijin
Copy link
Collaborator

kasugaijin commented Dec 6, 2024

@jmilljr24 @Aaryanpal yeah I think we should stick with the shadow on the image instead of the grey background. It is much easier to implement with CSS. @Aaryanpal how do you feel about taking that on to make all of the images use a shadow instead of grey background? Should be a pretty quick fix?

@kasugaijin
Copy link
Collaborator

@Aaryanpal bump - just checking if you're still able to refactor images per above comments? Thanks!

@jasonwang7517
Copy link
Contributor

I can take over this PR from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants