Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1097 - Update Sign Up form UI #1194

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

Meri-MG
Copy link
Contributor

@Meri-MG Meri-MG commented Nov 28, 2024

🔗 Issue

#1097

✍️ Description

Sign up form UI should look like Log in form UI.

📷 Screenshots/Demos

Screenshot 2024-12-11 at 20 58 15

@jmilljr24
Copy link
Collaborator

jmilljr24 commented Nov 28, 2024

@Meri-MG Can you merge the main branch into this? The org setting's page link is fixed in main. You can then attach a test logo. The layout looks great!! Just want to make sure the logo displays properly.
Screenshot from 2024-11-28 08-55-14

@Meri-MG
Copy link
Contributor Author

Meri-MG commented Nov 28, 2024

Hi, @jmilljr24 , I merged main branch in but i dont see the new logo in the pages

@jmilljr24
Copy link
Collaborator

jmilljr24 commented Nov 28, 2024

Hi, @jmilljr24 , I merged main branch in but i dont see the new logo in the pages

There isn't a default image. I just uploaded a photo from my computer. Any image you have available to attach should work that is mostly square shape as that is what logo's will most likely be.

@jmilljr24
Copy link
Collaborator

jmilljr24 commented Nov 28, 2024

I don't think we have any constraints on photo dimensions for uploads though. So for the time being you will probably need to adjust the photo on the frontend. We have something similar on the org home index page. class="ratio ratio-1x1 w-100 border border-0" . Check out bootstrap docs. Adjust accordingly for size etc...

Edit: This is my photo displayed so we will need something to adjust.
Screenshot from 2024-11-28 08-54-49

@kasugaijin
Copy link
Collaborator

@Meri-MG how's this one going? Let us know if you have any questions.

@Meri-MG
Copy link
Contributor Author

Meri-MG commented Dec 11, 2024

@Meri-MG how's this one going? Let us know if you have any questions.

ohhh, it's been two weeks, for some reason I thought the branch was merged, will address @jmilljr24 feedback at the end of this week

@Meri-MG
Copy link
Contributor Author

Meri-MG commented Dec 11, 2024

Screenshot 2024-12-11 at 17 05 23

are we okay with this kind of layout? or should the image be smaller as below?

Screenshot 2024-12-11 at 17 07 24

@kasugaijin
Copy link
Collaborator

Screenshot 2024-12-11 at 17 05 23 are we okay with this kind of layout? or should the image be smaller as below? Screenshot 2024-12-11 at 17 07 24

@Meri-MG haha nice picture. Given it is a logo it should be small, like 30x30 pixels

Copy link
Collaborator

@jmilljr24 jmilljr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Meri-MG Looks good. Thanks

@jmilljr24 jmilljr24 merged commit ce8ab91 into rubyforgood:main Dec 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants