1106-staff-deactivation-refactor

[wandergithub]

🔗 Issue

#1106

✍️ Description

Refactor staff deactivation

📷 Screenshots/Demos

[jmilljr24]

@wandergithub Awesome job!

The only thing I noticed on my end is that the flash is no longer working. Are you seeing the same thing?

This is on the main branch:

[wandergithub]

Now that you point that out 🤔
I will take a look.

[wandergithub]

Something is happening with the template, I think related to turbo stream and how the flash message is being handled but I don't fully understand how it works jet...

[jmilljr24]

Something is happening with the template, I think related to turbo stream and how the flash message is being handled but I don't fully understand how it works jet...

The update action in ActivationsController is implicitly looking for update.turbo_stream.erb in views/organizations/activations. You can explicitly render a file that is in a differently path but we probably should stick with convention unless there is a specific reason you can think of not to.

[kasugaijin]

Yeah what @jmilljr24 said. Check out app/views/organizations/staff/staff/update_activation.turbo_stream.erb. You need this for your new controller and action, so just move that turbo stream view file to the correct view directory for that new controller and rename it to update.turbo_stream.erb. You will note that this file does two things. It replaces the toggle because it should change after changing the activation, and it renders the flash.

[jmilljr24]

Yeah what @jmilljr24 said. Check out app/views/organizations/staff/staff/update_activation.turbo_stream.erb. You need this for your new controller and action, so just move that turbo stream view file to the correct view directory for that new controller and rename it to update.turbo_stream.erb. You will note that this file does two things. It replaces the toggle because it should change after changing the activation, and it renders the flash.

@kasugaijin I don't believe we need the turbo replace of the toggle any longer. I think that was used when the page was rendering two layouts that were user selected(table vs cards). If the user clicked the toggle in the table, the card wouldn't reflect the change until a page fresh.

[kasugaijin]

@jmilljr24 Ah yes we got rid of those cards...good point. We can remove the toggle bit in the turbostream response, then @wandergithub !

[wandergithub]

It works now!

Thanks guys. Now I understand better how turbo_streams and the real-time update work.

[kasugaijin]

Looks nice and clean @wandergithub ! I like the refactor.
Just a couple more policy tests we could add now we are also mutating adopters and fosters. Should be a pretty quick addition. Let me know if you have any questions!

[kasugaijin]

@wandergithub just pining to see if you can finish those last few tests? If you're too busy, let me know and I can take care of it.

[kasugaijin]

@wandergithub I finished this one off! Thanks for getting it to where it was.