Skip to content

Commit

Permalink
Add simplebar which was missing to get sidebar styling correct
Browse files Browse the repository at this point in the history
  • Loading branch information
edwinthinks committed Sep 26, 2023
1 parent d520e88 commit 8e96219
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions app/views/layouts/shared/_head.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

<%= stylesheet_link_tag "application", "data-turbo-track": "reload" %>
<%= javascript_importmap_tags %>
<link rel="stylesheet" href="https://unpkg.com/simplebar@latest/dist/simplebar.css" />

<% if content_for?(:head) %>
<%= yield(:head) %>
Expand Down
4 changes: 4 additions & 0 deletions config/importmap.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,7 @@

pin "chartkick", to: "chartkick.js"
pin "Chart.bundle", to: "Chart.bundle.js"
pin "simplebar", to: "https://ga.jspm.io/npm:[email protected]/dist/index.mjs"
pin "can-use-dom", to: "https://ga.jspm.io/npm:[email protected]/index.js"
pin "lodash-es", to: "https://ga.jspm.io/npm:[email protected]/lodash.js"
pin "simplebar-core", to: "https://ga.jspm.io/npm:[email protected]/dist/index.mjs"

1 comment on commit 8e96219

@kasugaijin
Copy link
Collaborator

@kasugaijin kasugaijin commented on 8e96219 Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this hide the navbar options? They are in the DOM but not visible in the UI. I think they are behind the nav element or something...looking at it now.

There's display: flex css being added somewhere. Removing that on the top nav element fixes the issue. Not sure where it's coming from in the erb file yet.

Please sign in to comment.