Removes adopter foster profile (#906)

* Remove adopter foster profile * lint * comment for later * fix test
rubyforgood · Aug 3, 2024 · 10f77cf · 10f77cf
1 parent 661f0a3
commit 10f77cf
Show file tree

Hide file tree

Showing 55 changed files with 53 additions and 2,778 deletions.
diff --git a/app/controllers/organizations/adopter_fosterer/profiles_controller.rb b/app/controllers/organizations/adopter_fosterer/profiles_controller.rb
diff --git a/app/controllers/organizations/staff/profile_reviews_controller.rb b/app/controllers/organizations/staff/profile_reviews_controller.rb
diff --git a/app/javascript/controllers/display_controller.js b/app/javascript/controllers/display_controller.js
diff --git a/app/models/adopter_foster_account.rb b/app/models/adopter_foster_account.rb
@@ -20,7 +20,6 @@
 class AdopterFosterAccount < ApplicationRecord
   acts_as_tenant(:organization)
   belongs_to :user
-  has_one :adopter_foster_profile, dependent: :destroy
   has_many :adopter_applications, dependent: :destroy
   has_many :matches, dependent: :destroy
   has_many :likes, dependent: :destroy

diff --git a/app/models/adopter_foster_profile.rb b/app/models/adopter_foster_profile.rb
diff --git a/app/models/concerns/authorizable.rb b/app/models/concerns/authorizable.rb
@@ -14,16 +14,12 @@ def permission?(name)
     create_adopter_applications
     view_adopter_applications
     withdraw_adopter_applications
-    create_adopter_foster_profiles
-    manage_adopter_foster_profiles
     purge_avatar
     manage_likes
   ].freeze
 
   FOSTERER_PERMISSIONS = %i[
     view_adopter_foster_dashboard
-    create_adopter_foster_profiles
-    manage_adopter_foster_profiles
     purge_avatar
   ].freeze
 
@@ -32,14 +28,11 @@ def permission?(name)
       %i[
         view_adopter_foster_dashboard
         create_adopter_applications
-        create_adopter_foster_profiles
-        manage_adopter_foster_profiles
         manage_likes
       ]
     ) + %i[
       review_adopter_applications
       view_adopter_foster_accounts
-      view_adopter_foster_profiles
       invite_fosterers
       purge_attachments
       manage_default_pet_tasks

diff --git a/app/models/location.rb b/app/models/location.rb
@@ -21,7 +21,6 @@
 #
 class Location < ApplicationRecord
   acts_as_tenant(:organization)
-  has_one :adopter_foster_profile
 
   validates :country, presence: true, length: {maximum: 50, message: "50 characters maximum"}
   validates :city_town, presence: true, length: {maximum: 50, message: "50 characters maximum"}

diff --git a/app/models/match.rb b/app/models/match.rb
@@ -29,7 +29,6 @@ class Match < ApplicationRecord
   belongs_to :adopter_foster_account
 
   has_one :user, through: :adopter_foster_account
-  has_one :adopter_foster_profile, through: :adopter_foster_account
 
   validates :start_date,
     presence: {if: -> { match_type == "foster" }}

diff --git a/app/policies/adopter_application_policy.rb b/app/policies/adopter_application_policy.rb
@@ -33,8 +33,7 @@ def already_applied?
   end
 
   def verify_profile!
-    deny! unless user.adopter_foster_account.present?
-    deny! unless user.adopter_foster_account.adopter_foster_profile.present?
+    deny! unless user.adopter_foster_account.present? # UPDATE THIS TO CHECK FOR FORMSUBMISSION INSTEAD OF PROFILE
   end
 
   def verify_pet_appliable!

diff --git a/app/policies/organizations/adopter_foster_profile_policy.rb b/app/policies/organizations/adopter_foster_profile_policy.rb
diff --git a/app/policies/organizations/profile_review_policy.rb b/app/policies/organizations/profile_review_policy.rb
diff --git a/app/views/organizations/adopter_fosterer/dashboard/index.html.erb b/app/views/organizations/adopter_fosterer/dashboard/index.html.erb
@@ -2,7 +2,7 @@
   <% c.with_header_title { t("dashboard.index.header_title") } %>
   <% c.with_body do %>
     <div class="row">
-      <% unless current_user.adopter_foster_account.adopter_foster_profile.present? %>
+      <% unless current_user.adopter_foster_account.present? %>
         <div class="alert alert-warning ">
           <%= link_to t('organizations.adoptable_pets.show.complete_my_profile'), new_adopter_fosterer_profile_path,
                             class: 'custom-btn-pink' %>