Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 5780 #5991
Fix 5780 #5991
Changes from 17 commits
077888b
13ac07d
5dcd091
89e38ff
4f441f9
ac6d735
f63a76b
00d522d
d2c47c2
bf36ae1
6fe1d04
cca8df1
c49f427
1de908c
61e332b
c649a51
4ba2aca
bd7237f
a966bc5
798eee1
3979c9e
be506a9
ff85445
9262d03
4d3bcf3
bb6f003
38353a0
630bb24
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use the placement policy for this. You should be able to do something like Placement.authorize.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrap with
p
orspan
some kind of html element. same with "Unknown" below.I don't love all of these paragraphs being wrapped by a heading (h6) element. Should that h6 just be for "Current Placement"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to keep it similar to other casa_case partials. the
h6
includes Current Placement and the placement_type, but now excludes the link to "See All Placements" (though its CSS was being overridden anyway)This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confusing, these aren't placement types, they are just type names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think the placement_names change should be made at the least:
This comment was marked as resolved.
Sorry, something went wrong.