Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Line Chart: MAU (Monthly Active Users) by User Type #5724

Merged
merged 2 commits into from
May 19, 2024

Conversation

sarvaiyanidhi
Copy link
Contributor

What github issue is this PR for, if any?

Resolves #5723

What changed, and why?

Need to fix Monthly Active Users chart data by fetching details from new table login_activity which tracks history of User's login to calculate correct details.

How is this tested? (please write tests!) 💖💪

Added tests to check calculation based on data.

Screenshots please :)

CASA-MAU

Feelings gif (optional)

What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:

![alt text](https://media.giphy.com/media/1nP7ThJFes5pgXKUNf/giphy.gif)

@github-actions github-actions bot added ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels May 18, 2024
Copy link
Collaborator

@compwron compwron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@compwron compwron merged commit 06b5fd4 into rubyforgood:main May 19, 2024
15 of 16 checks passed
@bcastillo32
Copy link
Collaborator

@sarvaiyanidhi will the chart look more "Normal" going forward? I'm trying to remember what we discussed to understand why prior months are flat
image

@sarvaiyanidhi
Copy link
Contributor Author

Yes, as we started tracking user login activities in separate table from May onwards so now chart should show up correct details going forward. I will be also keeping check on it but do let me know if you find any discrepancy in numbers.

Also, I have started on WAU coding as well as we discussed to show WAU in period of Week, Month, Quarter and Year. Will release it soon. Just for your reference, this is how I am planning to show on chart two dropdowns. Period dropdown will be enabled only when chart type option is WAU and disabled when chart type is MAU

image_2024-06-12_170303207

@bcastillo32
Copy link
Collaborator

Yes, as we started tracking user login activities in separate table from May onwards so now chart should show up correct details going forward. I will be also keeping check on it but do let me know if you find any discrepancy in numbers.

Also, I have started on WAU coding as well as we discussed to show WAU in period of Week, Month, Quarter and Year. Will release it soon. Just for your reference, this is how I am planning to show on chart two dropdowns. Period dropdown will be enabled only when chart type option is WAU and disabled when chart type is MAU

image_2024-06-12_170303207

ok great! Thank you for the feedback and reminder about how this will work going forward. The WAU and Time period dropdown looks great! :)

@bcastillo32
Copy link
Collaborator

Yes, as we started tracking user login activities in separate table from May onwards so now chart should show up correct details going forward. I will be also keeping check on it but do let me know if you find any discrepancy in numbers.

Also, I have started on WAU coding as well as we discussed to show WAU in period of Week, Month, Quarter and Year. Will release it soon. Just for your reference, this is how I am planning to show on chart two dropdowns. Period dropdown will be enabled only when chart type option is WAU and disabled when chart type is MAU

image_2024-06-12_170303207

Hi @sarvaiyanidhi is the MAU/WAU and time period dropdowns still being worked on?

@sarvaiyanidhi
Copy link
Contributor Author

Hi @bcastillo32 , Sorry, I completely missed out on completing this issue but will like to get back to it and close it. I see that issue #5589 got unassigned last month.. Can you please reassign it to me? I just need to recheck once code where it was left and may reconnect with you in issue if I need re-clarification on our last discussion on WAU details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code Tests! 🎉💖👏
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Fix Month Active User (MAU) Line Chart Data by User Type
3 participants