Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case Contact Form Bug #5641

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Case Contact Form Bug #5641

merged 1 commit into from
Apr 26, 2024

Conversation

schoork
Copy link
Collaborator

@schoork schoork commented Apr 26, 2024

What github issue is this PR for, if any?

https://rubyforgood.slack.com/archives/G01143RQ7DG/p1714155460842599

What changed, and why?

How will this affect user permissions?

  • Volunteer permissions:
  • Supervisor permissions:
  • Admin permissions:

How is this tested? (please write tests!) 💖💪

Screenshots please :)

Feelings gif (optional)

What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
![alt text](https://media.giphy.com/media/1nP7ThJFes5pgXKUNf/giphy.gif)

Feedback please? (optional)

We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9

@github-actions github-actions bot added ruby Pull requests that update Ruby code erb labels Apr 26, 2024
@schoork schoork changed the title Fixed Case Contact Form Bug Apr 26, 2024
Copy link
Collaborator

@compwron compwron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dear. We must be missing a very important test somewhere... let's put that in when we can.

@compwron compwron merged commit 125ec6f into main Apr 26, 2024
11 of 13 checks passed
@compwron compwron deleted the case-contact-form-bug-fix branch April 26, 2024 19:17
@compwron
Copy link
Collaborator

There appears to be an issue with the case contact form. Jocie let me know during the stakeholder meeting that volunteers are not able to submit contacts and are getting a number of errors. This seems to affect all organizations. One volunteer told her they got a 504 error. Another volunteers said that they got the error message on page 3 after they tried to type notes. Another said that they are getting an error that the contact has already been submitted when they're trying to save it.

compwron added a commit that referenced this pull request May 5, 2024
Add tests for previously merged commits: #5643, #5642, #5641
This was referenced May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
erb ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants