improve invalid factorybot linter, some specs #5570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compwron
commented
Apr 14, 2024
| @@ -58,7 +58,6 @@ | |||
| end | |||
|
|
|||
| trait :expenses_status do | |||
| casa_case { nil } | |||
There was a problem hiding this comment.
this was invalid and seemed bad so I removed it
compwron
commented
Apr 14, 2024
| @@ -5,7 +5,8 @@ | |||
|
|
|||
| trait :with_casa_cases do | |||
| after(:create) do |user, _| | |||
| create_list(:case_assignment, 2, volunteer: user) | |||
| volunteer = create(:volunteer) | |||
There was a problem hiding this comment.
the user in this case is I believe the supervisor. The cases should not be assigned to the supervisor.
compwron
commented
Apr 14, 2024
| @@ -12,7 +12,7 @@ | |||
| token { "verysecuretoken" } | |||
|
|
|||
| trait :inactive do | |||
| volunteer | |||
| type { "Volunteer" } | |||
There was a problem hiding this comment.
this previous way was simply not working I think
compwron
commented
Apr 14, 2024
| @@ -109,17 +109,23 @@ | |||
| end | |||
|
|
|||
| it "requires duration minutes" do | |||
| expect(build_stubbed(:case_contact, :details_status, duration_minutes: nil)).not_to be_valid | |||
| obj = build_stubbed(:case_contact, :details_status, duration_minutes: nil) | |||
There was a problem hiding this comment.
better testing of errors - I'd like more good testing of errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
factorybot linting