Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Notification class to control notification components created by the notifier #5248

Merged
merged 29 commits into from
Oct 7, 2023
Merged

New Notification class to control notification components created by the notifier #5248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
505dbe5
created new reusbale js form validator
FireLemons Sep 24, 2023
2bb594d
Created new notification class with stubs
FireLemons Sep 29, 2023
cef384e
wrap text in span to make it more accessible
FireLemons Sep 30, 2023
b134f47
filled in settext and gettext for notification class
FireLemons Sep 30, 2023
056b833
update tests
FireLemons Sep 30, 2023
cc418d7
finished notification class
FireLemons Oct 2, 2023
0bf8871
make throwErrorIfDismissed private
FireLemons Oct 2, 2023
4dea69e
separate old tests and add section with stubs for notification tests
FireLemons Oct 2, 2023
7f49ee7
fixed wrong level name
FireLemons Oct 2, 2023
1ed268a
wrote tests for dismiss, fixed conditional to check if notification h…
FireLemons Oct 3, 2023
ddf3152
linter
FireLemons Oct 3, 2023
84c68ce
created getText test
FireLemons Oct 3, 2023
63be57f
get validated form component working
FireLemons Oct 4, 2023
d0c35c9
revert component usage
FireLemons Oct 4, 2023
418f2a8
gave method better name
FireLemons Oct 4, 2023
b3a4bd3
stubbed tests, shortened wording on some tests, comments for jQuery c…
FireLemons Oct 4, 2023
0c8cc31
one is enough
FireLemons Oct 4, 2023
d504bf1
created test for isUserDismissable
FireLemons Oct 5, 2023
609b0eb
combined tests
FireLemons Oct 5, 2023
3ce1c38
filled in isDismissed test
FireLemons Oct 6, 2023
b7dddd0
corrected test, added test for isDismissable when notification is dis…
FireLemons Oct 6, 2023
32f34ca
added test for enable user dismiss button, fixed setUserDismissable b…
FireLemons Oct 6, 2023
4e19172
added tests for Notification constructor
FireLemons Oct 7, 2023
feee3a1
added tests preventing setUserDismissable from making unexpected changes
FireLemons Oct 7, 2023
99d0738
filled in rest of setUserDismissable
FireLemons Oct 7, 2023
78ec022
filled in tests for setText
FireLemons Oct 7, 2023
2eb2f74
fixed toggle calling old function name, created test for toggleUserDi…
FireLemons Oct 7, 2023
e6db61e
remove debug print
FireLemons Oct 7, 2023
b0c9f1a
filled out test to toggle from user dismissable state
FireLemons Oct 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/assets/stylesheets/shared/notifier.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@
margin: .25em;
margin-left: auto;
margin-right: 0;
padding: .5em
padding: .5em;

span {
display: inline
}
}

.failure-indicator {
Expand Down
Loading