fix 403 error, add error catching and logging

rubyforgood · Apr 15, 2024 · 05d7317 · 05d7317
1 parent ccdb08b
commit 05d7317
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb
@@ -15,6 +15,7 @@ class ApplicationController < ActionController::Base
 
   rescue_from Pundit::NotAuthorizedError, with: :not_authorized
   rescue_from Organizational::UnknownOrganization, with: :not_authorized
+  rescue_from StandardError, with: :log_and_reraise
 
   impersonates :user
 
@@ -134,6 +135,11 @@ def not_authorized
     redirect_to(root_url)
   end
 
+  def log_and_reraise(error)
+    Bugsnag.notify(error)
+    raise error
+  end
+
   def check_unconfirmed_email_notice(user)
     notice = "#{user.role} was successfully updated."
     if user.saved_changes.include?("unconfirmed_email")

diff --git a/public/403.html b/public/403.html
@@ -1,7 +1,7 @@
 <!DOCTYPE html>
 <html>
 <head>
-  <title>We're sorry, but something went wrong (500)</title>
+  <title>We're sorry, but something went wrong (403)</title>
   <meta name="viewport" content="width=device-width,initial-scale=1">
   <style>
   .rails-default-error-page {