Migrate bourbon and neat from bower to npm #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmmm. guess we'll need to upgrade the major versions if we want the |
hussam-i-am
commented
Oct 20, 2023
hussam-i-am
commented
Oct 20, 2023
hussam-i-am
commented
Oct 20, 2023
hussam-i-am
commented
Oct 20, 2023
Tonkpils
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes bourbon and bourbon-neat from as bower dependencies, including them instead as node dependencies. I was getting build errors when trying to use the exact versions used in bower, so upgraded them to use the latest versions and had to make some adjustments to the sass. Tested the frontend and compared it to production, and did not come across any major discrepancies, other than some very minor margin changes with the
BackandNextbuttons on some of the pages.