Upgrade sass to support Node 16+ #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussam-i-am
changed the title
hussam-i-am
force-pushed
the
hussam-i-am/node-sass-upgrade
branch
from
750664c to
ce345af
Compare
|
✨ this looks straight forward although I'm not super familiar with the upgrade process for sass. It looks like there's some deprecation notices in the CI run https://github.com/rubyforgood/Flaredown/actions/runs/6397479951/job/17365494297?pr=677#step:6:33 Would you mind addressing those? It's encouraging that all tests seems to pass now for all the node versions. I'll give this a spin locally and in staging to see if things are working as expected and get back to you when I do 🙇 |
|
@Tonkpils I believe the notices are for usages from within |
Tonkpils
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request to the frontend package updates dependencies and package versions, and uses the
sass:mathmodule to update variable and property calculations in various SCSS files.frontend/package.json: Updated dependencies and package version. (Update dependencies and package version in frontend/package.json)frontend/app/styles/bitters/_variables.scss: Updated calculation for$small-spacingusing thesass:mathmodule. (Update variable calculation, Import module)frontend/app/styles/bitters/_forms.scss: Imported and used themathmodule to update property calculations for padding, margin-right, and margin-bottom in various selectors. (Import and usemathmodule to update property calculations in_forms.scss)