Fix memory leak in util_spec_rb_get_kwargs #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call to rb_get_kwargs could raise an exception, which would cause the ids and results to be leaked. This commit changes these two to be allocated on the stack using alloca instead of malloc so we don't need to free it.
peterzhu2118
force-pushed
the
rb-get-kwargs-mem-leak
branch
from
6fc4f9e to
20ed73a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to rb_get_kwargs could raise an exception, which would cause the ids and results to be leaked. This commit changes these two to be allocated on the stack using alloca instead of malloc so we don't need to free it.