Merge specs of UNIXSocket.pair and UNIXSocket.socketpair into a shared spec #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods are aliases. This change is to make it easier to see that we added a combination of both specs. This makes it easier to convert it into a shared spec
|
This is a second attempt at #1131, because I've had commit permissions for 1 day and I already screwed things up by merging the wrong branch |
|
I'm confused, this seems to have the same commits as #1131 which is merged (and looks alright and CI passed). |
|
It seems the #1131's commits were removed in the master branch. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods are aliases, so we probably shouldn't have two separate specs hanging around.