Cleanup of YAML specs #1108
Merged
Cleanup of YAML specs #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
herwinw
commented
Nov 12, 2023
herwinw
commented
- Fix confusion over instance and class variables in descriptions
- Remove globals
Replace it with a call to `fixture`.
Use instance variables and before/after blocks instead.
The only line left was `require "yaml"`, use that inline.
| YAML.dump( ['badger', 'elephant', 'tiger'], io ) | ||
| end | ||
| YAML.load_file($test_file).should == ['badger', 'elephant', 'tiger'] | ||
| YAML.load_file(@test_file).should == ['badger', 'elephant', 'tiger'] | ||
| end |
There was a problem hiding this comment.
suggestion: $test_file was used in one case only - it makes sense not to create and delete file for every other cases.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.