Add type for Enumerator::Chain
#2220
Open
+41
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadoxV5
force-pushed
the
enumerator-chain
branch
from
85363f5 to
3574120
Compare
ParadoxV5
force-pushed
the
enumerator-chain
branch
from
3574120 to
eb2f558
Compare
ParadoxV5
changed the title
Enumerator::Chain::newEnumerator::Chain
ParadoxV5
commented
Jan 8, 2025
core/enumerator.rbs
Outdated
| @@ -612,19 +612,24 @@ end | |||
| # | |||
| # This type of objects can be created by Enumerable#chain and Enumerator#+. | |||
| # | |||
| class Enumerator::Chain[out Elem] < Enumerator[Elem, void] | |||
| include Enumerable[Elem] | |||
| class Enumerator::Chain[out Elem] < Enumerator[Elem, void] # Rubocop: `self` type is not allowed in this context | |||
There was a problem hiding this comment.
Why isn’t it allowed?
There was a problem hiding this comment.
Also, rake annotate deletes this comment.
Comment on lines
+632
to
+649
| # wrong argument type chain (expected enumerator) (TypeError) | ||
| def with_index: (?Integer) ?{ (?) -> untyped } -> bot | ||
| def each_with_index: () ?{ (?) -> untyped } -> bot |
|
CI: Local: $ rake templates
/usr/local/bin/ruby templates/template.rb include/rbs/constants.h
/usr/local/bin/ruby templates/template.rb include/rbs/ruby_objs.h
/usr/local/bin/ruby templates/template.rb src/constants.c
/usr/local/bin/ruby templates/template.rb src/ruby_objs.c
$ git diff
$ echo $?
0 |
ParadoxV5
force-pushed
the
enumerator-chain
branch
from
eb2f558 to
cfb8ed6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.