Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Concurrent::Map #500

Merged

Conversation

sw-square
Copy link
Contributor

@sw-square sw-square commented Jan 22, 2024

This adds all of the methods for Concurrent::Map. It uses some metaprogramming to define superclasses/not implement methods based on which implementation of ruby it's running on, so I implemented the greatest denominator (no super class and implement all methods)

@sw-square sw-square requested a review from pocke as a code owner January 22, 2024 21:47
@sw-square sw-square force-pushed the swesterman/24-01-22/update-concurrent-map branch from 4f18081 to 2685aab Compare January 22, 2024 21:49
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soutaro soutaro merged commit 29f6387 into ruby:main Jan 25, 2024
3 checks passed
pocke added a commit to pocke/gem_rbs_collection that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants