Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Types for ActiveSupport::SecurityUtils #463

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Add Types for ActiveSupport::SecurityUtils #463

merged 2 commits into from
Jan 25, 2024

Conversation

m11o
Copy link
Contributor

@m11o m11o commented Oct 28, 2023

Add types for secure_compare and fixed_length_secure_compare methods in ActiveSupport::SecurityUtils

ref: https://github.com/rails/rails/blob/v6.0.6.1/activesupport/lib/active_support/security_utils.rb

@m11o m11o requested a review from pocke as a code owner October 28, 2023 12:09
@pocke
Copy link
Member

pocke commented Jan 25, 2024

Please fix the conflict.

@m11o
Copy link
Contributor Author

m11o commented Jan 25, 2024

Thank you for your review. I fixed it.

pocke
pocke approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@pocke pocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for my absence 🙏

@pocke pocke merged commit e8eb9ed into ruby:main Jan 25, 2024
3 checks passed
@m11o
Copy link
Contributor Author

m11o commented Jan 25, 2024

No problem! 👍 I always appreciate your reviews.

@m11o m11o deleted the feature/add-types-for-security-utils branch January 25, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pocke pocke pocke approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m11o @pocke