Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

active_hash: Fix the type of block argument for ActiveHash::Relation#find #457

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

tk0miya
Copy link
Contributor

@tk0miya tk0miya commented Oct 22, 2023

The block should take an instance of ActiveHash::Base object, not a relation object itself.

…find

The block should take an instance of ActiveHash::Base object, not a
relation object itself.
@tk0miya tk0miya requested a review from pocke as a code owner October 22, 2023 06:14
@pocke pocke merged commit 26cba01 into ruby:main Oct 28, 2023
3 checks passed
@tk0miya tk0miya deleted the fix_active_hash_relation_find branch October 28, 2023 16:21
sw-square pushed a commit to sw-square/gem_rbs_collection that referenced this pull request Jan 22, 2024
…find (ruby#457)

The block should take an instance of ActiveHash::Base object, not a
relation object itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants